Repository navigation
Add typed JSON output to theme check - #8642
Open
gonzaloriestra wants to merge 9 commits into
Open
gonzaloriestra wants to merge 9 commits into
gonzaloriestra wants to merge 9 commits into
Conversation
gonzaloriestra
added this pull request to stack #8644
September 24, 2026 09:19
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 10:04
60fc145 to
84774fa
Compare
gonzaloriestra
removed this pull request from stack #8644
September 24, 2026 10:04
gonzaloriestra
changed the base branch from
gonzalo/json-theme-list
to
gonzalo/json-theme-preview
September 24, 2026 10:05
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 10:11
84774fa to
143d3dc
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
2 times, most recently
from
September 24, 2026 10:21
1e151c5 to
0bd24e9
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 10:25
0bd24e9 to
b1a9aff
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 11:56
b1a9aff to
cd8b847
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 13:46
cd8b847 to
ec6f23d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 14:21
ec6f23d to
861825a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
2 times, most recently
from
September 25, 2026 11:43
6cae74e to
c218adb
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
2 times, most recently
from
September 25, 2026 12:27
fa74b25 to
d93ff1e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 29, 2026 13:44
0dbe925 to
8a82337
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
2 times, most recently
from
September 29, 2026 14:40
04343fc to
c6e17b3
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
October 1, 2026 08:52
c6e17b3 to
9393b37
Compare
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:18
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
October 6, 2026 12:29
9393b37 to
a010fb4
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
October 6, 2026 12:31
a010fb4 to
05b9d68
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
October 6, 2026 13:53
05b9d68 to
d5b00ff
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
October 6, 2026 13:56
d5b00ff to
52ed921
Compare
Contributor
|
| Changeset | Package |
|---|---|
theme-check-json-contract.md |
'@shopify/cli': major |
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
theme-preview-json-contract.md |
'@shopify/cli': major |
theme-push-json-contract.md |
"@shopify/cli": major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,5 +11,12 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<Theme>;
+ create(themeRole?: Role, themeName?: string): Promise<{
+ createdAtRuntime: boolean;
+ id: number;
+ name: string;
+ processing: boolean;
+ role: string;
+ src?: string;
+ }>;
}
\ No newline at end of file
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Theme Check JSON needs consistent validation results and diagnostic fields.
WHAT is this pull request doing?
Return valid, flat issues and consistent severity counts with absolute file paths and zero-based camelCase positions. Retain completed validation in environment batches, honor the blocking policy, and wait for requested corrections before final JSON.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add