Repository navigation
Add typed JSON output to theme preview - #8645
Open
gonzaloriestra wants to merge 5 commits into
Open
gonzaloriestra wants to merge 5 commits into
gonzaloriestra wants to merge 5 commits into
Conversation
gonzaloriestra
added this pull request to stack #8646
September 24, 2026 09:23
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 10:04
ebf024f to
fda3575
Compare
gonzaloriestra
removed this pull request from stack #8646
September 24, 2026 10:04
gonzaloriestra
changed the base branch from
gonzalo/json-theme-open
to
gonzalo/json-theme-share
September 24, 2026 10:05
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 10:13
fda3575 to
f82379b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 10:25
f82379b to
f8f160d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 11:56
f8f160d to
781de0e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 13:46
781de0e to
a523b13
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 14:21
a523b13 to
571cd4e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 14:36
571cd4e to
814fcb9
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 25, 2026 11:43
814fcb9 to
ecb184c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 25, 2026 11:59
ecb184c to
a6c90ed
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 25, 2026 12:28
a6c90ed to
8cfc448
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 29, 2026 13:44
188cf16 to
ccc8179
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
2 times, most recently
from
September 29, 2026 14:40
56b039f to
86fe745
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
October 1, 2026 08:52
86fe745 to
1f370d0
Compare
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:18
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
October 6, 2026 12:29
1f370d0 to
ff44bf7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
3 times, most recently
from
October 6, 2026 13:56
ed6c15c to
20a2271
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
October 8, 2026 08:27
20a2271 to
c88286d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
October 8, 2026 08:43
c88286d to
8e94e8b
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,5 +11,12 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<Theme>;
+ create(themeRole?: Role, themeName?: string): Promise<{
+ createdAtRuntime: boolean;
+ id: number;
+ name: string;
+ processing: boolean;
+ role: string;
+ src?: string;
+ }>;
}
\ No newline at end of file
|
Contributor
|
| Changeset | Package |
|---|---|
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
theme-preview-json-contract.md |
'@shopify/cli': major |
theme-push-json-contract.md |
"@shopify/cli": major |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Preview JSON should expose a stable resource and wait for browser diagnostics.
WHAT is this pull request doing?
Return a strict preview resource with an opaque string ID and validated URL. Keep the native service compatibility adapter, await browser warnings before final output, and retain explicit environment batches.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add