Repository navigation
Add typed JSON output to theme push - #8647
Open
gonzaloriestra wants to merge 13 commits into
Open
gonzaloriestra wants to merge 13 commits into
gonzaloriestra wants to merge 13 commits into
Conversation
gonzaloriestra
added this pull request to stack #8650
September 24, 2026 09:31
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
from
September 24, 2026 10:04
16e4ae7 to
c3100fb
Compare
gonzaloriestra
removed this pull request from stack #8650
September 24, 2026 10:04
gonzaloriestra
changed the base branch from
main
to
gonzalo/json-theme-rename
September 24, 2026 10:05
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
2 times, most recently
from
September 24, 2026 10:25
96095dc to
ff21d01
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
from
September 24, 2026 11:56
ff21d01 to
4f412b3
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
2 times, most recently
from
September 24, 2026 14:21
a17bb51 to
e719f0c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
2 times, most recently
from
September 25, 2026 11:43
8afadb0 to
5c4a5e5
Compare
gonzaloriestra
marked this pull request as ready for review
September 25, 2026 11:56
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
from
September 25, 2026 11:59
5c4a5e5 to
8b08bde
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
from
September 25, 2026 12:28
8b08bde to
03e1631
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
from
October 6, 2026 12:31
2d89d0a to
a9620d2
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
from
October 6, 2026 13:53
a9620d2 to
0212668
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
from
October 6, 2026 13:56
0212668 to
d3a64d0
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
from
October 8, 2026 08:43
4be0587 to
23b8b0b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-push
branch
from
October 8, 2026 09:53
23b8b0b to
40b233b
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 10:04
Contributor
|
| Changeset | Package |
|---|---|
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
theme-push-json-contract.md |
"@shopify/cli": major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,5 +11,12 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<Theme>;
+ create(themeRole?: Role, themeName?: string): Promise<{
+ createdAtRuntime: boolean;
+ id: number;
+ name: string;
+ processing: boolean;
+ role: string;
+ src?: string;
+ }>;
}
\ No newline at end of file
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Upload JSON currently uses inconsistent field names and drops environment outcomes.
WHAT is this pull request doing?
Project string IDs, camelCase links and absolute-path upload issues. Report partial uploads with a nonzero exit, retain skipped/cancelled outcomes and every requested environment, and route failed operations through the shared error envelope.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add