Repository navigation
Add typed JSON output to theme pull - #8648
Open
gonzaloriestra wants to merge 10 commits into
Open
gonzaloriestra wants to merge 10 commits into
gonzaloriestra wants to merge 10 commits into
Conversation
gonzaloriestra
added this pull request to stack #8650
September 24, 2026 09:31
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
September 24, 2026 10:04
1fefc12 to
890c7ac
Compare
gonzaloriestra
removed this pull request from stack #8650
September 24, 2026 10:04
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
September 24, 2026 10:13
890c7ac to
76bb8a2
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
September 24, 2026 10:25
76bb8a2 to
24d32de
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
September 24, 2026 11:56
24d32de to
ca60dda
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
September 24, 2026 13:46
ca60dda to
be3adca
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
September 24, 2026 14:21
be3adca to
e0e000c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
September 24, 2026 14:36
e0e000c to
c9abe6c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
2 times, most recently
from
September 25, 2026 11:59
a42361d to
7c4257a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
September 25, 2026 12:28
7c4257a to
2c34792
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
September 28, 2026 08:20
2c34792 to
27e0bdd
Compare
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:18
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
October 6, 2026 12:29
234452b to
ed6134d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
2 times, most recently
from
October 6, 2026 13:53
9b5514f to
187a818
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
October 6, 2026 13:56
187a818 to
78c7a43
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
2 times, most recently
from
October 8, 2026 08:43
6acc19e to
c2d3901
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-pull
branch
from
October 8, 2026 09:53
c2d3901 to
d61a55e
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 10:04
Contributor
|
| Changeset | Package |
|---|---|
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
theme-push-json-contract.md |
"@shopify/cli": major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,5 +11,12 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<Theme>;
+ create(themeRole?: Role, themeName?: string): Promise<{
+ createdAtRuntime: boolean;
+ id: number;
+ name: string;
+ processing: boolean;
+ role: string;
+ src?: string;
+ }>;
}
\ No newline at end of file
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Theme downloads need a typed automation result.
WHAT is this pull request doing?
Add a strict JSON theme resource, absolute project directory and explicit outcomes. Retain cancellation, safety skips and all requested environment results while keeping download failures on the shared fatal path.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add