Repository navigation
Add typed JSON output to theme share - #8649
Open
gonzaloriestra wants to merge 7 commits into
Open
gonzaloriestra wants to merge 7 commits into
gonzaloriestra wants to merge 7 commits into
Conversation
gonzaloriestra
added this pull request to stack #8650
September 24, 2026 09:31
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
September 24, 2026 10:04
da398e8 to
9ea0fcf
Compare
gonzaloriestra
removed this pull request from stack #8650
September 24, 2026 10:04
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
September 24, 2026 10:13
9ea0fcf to
9ea9818
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
September 24, 2026 10:25
9ea9818 to
9b471ea
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
September 24, 2026 11:56
9b471ea to
6fa7e17
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
September 24, 2026 13:46
6fa7e17 to
27f1592
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
September 24, 2026 14:21
27f1592 to
42d54fc
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
September 24, 2026 14:36
42d54fc to
36bed07
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
September 25, 2026 11:43
36bed07 to
097f129
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
2 times, most recently
from
September 25, 2026 12:27
04d63cb to
7c078ff
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
September 28, 2026 08:20
7c078ff to
b0ff2cc
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
2 times, most recently
from
October 1, 2026 08:52
a0f46f1 to
91e0a87
Compare
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:18
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
2 times, most recently
from
October 6, 2026 12:31
def650f to
cde1d9d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
October 6, 2026 13:53
cde1d9d to
41248be
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
October 6, 2026 13:56
41248be to
0c010fa
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
October 8, 2026 08:27
0c010fa to
42ab5a2
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
October 8, 2026 08:43
42ab5a2 to
3a596a9
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-share
branch
from
October 8, 2026 09:53
3a596a9 to
9aa08a9
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 10:04
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,5 +11,12 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<Theme>;
+ create(themeRole?: Role, themeName?: string): Promise<{
+ createdAtRuntime: boolean;
+ id: number;
+ name: string;
+ processing: boolean;
+ role: string;
+ src?: string;
+ }>;
}
\ No newline at end of file
|
Contributor
|
| Changeset | Package |
|---|---|
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
theme-push-json-contract.md |
"@shopify/cli": major |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Shared themes need a consistent machine-readable upload result.
WHAT is this pull request doing?
Reuse the public upload projection for strict string IDs, camelCase links and absolute-path issues. Preserve partial uploads, cancellation and complete environment batches.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add