Repository navigation
Add typed JSON output to theme delete - #8651
Open
gonzaloriestra wants to merge 6 commits into
Open
gonzaloriestra wants to merge 6 commits into
gonzaloriestra wants to merge 6 commits into
Conversation
gonzaloriestra
added this pull request to stack #8654
September 24, 2026 09:47
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
September 24, 2026 10:04
8039b3f to
989d6ce
Compare
gonzaloriestra
removed this pull request from stack #8654
September 24, 2026 10:04
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
September 24, 2026 10:13
989d6ce to
67f7391
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
September 24, 2026 10:25
67f7391 to
184ceb6
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
2 times, most recently
from
September 24, 2026 13:46
14b3b11 to
e01e3ae
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
September 24, 2026 14:21
e01e3ae to
1f1fabf
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 14:22
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
2 times, most recently
from
September 25, 2026 12:27
4ddf016 to
4add04e
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
September 28, 2026 08:20
4add04e to
00f02a7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
September 28, 2026 10:25
00f02a7 to
8483445
Compare
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:18
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
October 6, 2026 12:29
f665300 to
6bc89c4
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
2 times, most recently
from
October 6, 2026 13:53
984bbfd to
e89e04e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
October 8, 2026 08:43
e89e04e to
aad6f88
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
October 8, 2026 09:53
aad6f88 to
b944412
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 10:04
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
October 9, 2026 12:00
b944412 to
f6c9f0a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
2 times, most recently
from
October 9, 2026 12:48
fd03a99 to
dc7a38c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
October 9, 2026 13:09
dc7a38c to
0594b82
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
October 9, 2026 13:19
0594b82 to
03bb155
Compare
Contributor
|
| Changeset | Package |
|---|---|
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Theme deletion needs machine-readable outcomes without losing successful deletions.
WHAT is this pull request doing?
Separate service data from presentation and add strict JSON results, cancellation objects and complete environment batches. Preserve successful deletions and item errors when deletion partly fails.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add