Skip to content

Add typed JSON output to theme delete - #8651

Open
gonzaloriestra wants to merge 6 commits into
gonzalo/json-theme-duplicatefrom
gonzalo/json-theme-delete
Open

gonzaloriestra wants to merge 6 commits into
gonzalo/json-theme-duplicatefrom
gonzalo/json-theme-delete

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Theme deletion needs machine-readable outcomes without losing successful deletions.

WHAT is this pull request doing?

Separate service data from presentation and add strict JSON results, cancellation objects and complete environment batches. Preserve successful deletions and item errors when deletion partly fails.

The public output follows docs/cli/json-output.md; explicitly named environments use one {environments: [...]} object.

How to manually test your changes?

shopify theme delete --theme <theme-id> --store example.myshopify.com --json
shopify theme delete --json-schema

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@gonzaloriestra
gonzaloriestra added this pull request to stack #8654 September 24, 2026 09:47
@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Sep 24, 2026
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from 8039b3f to 989d6ce Compare September 24, 2026 10:04
@gonzaloriestra
gonzaloriestra removed this pull request from stack #8654 September 24, 2026 10:04
@gonzaloriestra
gonzaloriestra added this pull request to stack #8655 September 24, 2026 10:05
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from 989d6ce to 67f7391 Compare September 24, 2026 10:13
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from 67f7391 to 184ceb6 Compare September 24, 2026 10:25
@github-actions github-actions Bot added no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. and removed Area: @shopify/cli @shopify/cli package issues labels Sep 24, 2026
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch 2 times, most recently from 14b3b11 to e01e3ae Compare September 24, 2026 13:46
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from e01e3ae to 1f1fabf Compare September 24, 2026 14:21
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review September 24, 2026 14:22
@gonzaloriestra
gonzaloriestra requested review from a team as code owners September 24, 2026 14:22
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch 2 times, most recently from 4ddf016 to 4add04e Compare September 25, 2026 12:27
@gonzaloriestra
gonzaloriestra removed this pull request from stack #8655 September 25, 2026 12:28
@gonzaloriestra
gonzaloriestra added this pull request to stack #8673 September 25, 2026 12:29
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from 4add04e to 00f02a7 Compare September 28, 2026 08:20
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from 00f02a7 to 8483445 Compare September 28, 2026 10:25
@gonzaloriestra
gonzaloriestra marked this pull request as draft October 6, 2026 12:18
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from f665300 to 6bc89c4 Compare October 6, 2026 12:29
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch 2 times, most recently from 984bbfd to e89e04e Compare October 6, 2026 13:53
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from e89e04e to aad6f88 Compare October 8, 2026 08:43
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from aad6f88 to b944412 Compare October 8, 2026 09:53
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review October 8, 2026 10:04
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from b944412 to f6c9f0a Compare October 9, 2026 12:00
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch 2 times, most recently from fd03a99 to dc7a38c Compare October 9, 2026 12:48
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from dc7a38c to 0594b82 Compare October 9, 2026 13:09
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-delete branch from 0594b82 to 03bb155 Compare October 9, 2026 13:19
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release.

📦 Major Version Changesets

The following changesets request a major version bump:

Changeset Package
theme-duplicate-json-contract.md '@shopify/cli': major
theme-info-json-contract.md '@shopify/cli': major
theme-list-json-contract.md '@shopify/cli': major
theme-open-json-contract.md '@shopify/cli': major

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/base-command.d.ts
@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
         argv: string[];
     }>;
     protected environmentsFilename(): string | undefined;
+    protected validateNonTTYFlags(flags: FlagOutput): void;
     protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
     private failMissingNonTTYFlagRequirements;
     private applicableNonTTYFlagRequirements;

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. shopify.dev preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants