Repository navigation
Add typed JSON output to theme rename - #8653
Open
gonzaloriestra wants to merge 6 commits into
Open
gonzaloriestra wants to merge 6 commits into
gonzaloriestra wants to merge 6 commits into
Conversation
gonzaloriestra
added this pull request to stack #8654
September 24, 2026 09:47
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
September 24, 2026 10:04
dd58dce to
9606a9a
Compare
gonzaloriestra
removed this pull request from stack #8654
September 24, 2026 10:04
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
September 24, 2026 10:13
9606a9a to
7336e0a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
September 24, 2026 10:25
7336e0a to
83e17cf
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
September 24, 2026 11:56
83e17cf to
32c0974
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
September 24, 2026 13:46
32c0974 to
97f10b5
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
2 times, most recently
from
September 24, 2026 14:36
769c88d to
e2e7e23
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 14:45
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
September 25, 2026 12:27
e2e7e23 to
fb17cc3
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
2 times, most recently
from
September 28, 2026 10:25
79b50fd to
7975e76
Compare
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:18
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
October 6, 2026 12:29
8f1bb98 to
4125aed
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
October 6, 2026 12:31
4125aed to
c50e130
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
October 6, 2026 13:53
c50e130 to
8444c3c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
October 8, 2026 08:43
8444c3c to
3f41b98
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
October 8, 2026 09:53
3f41b98 to
0699aba
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 10:04
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
2 times, most recently
from
October 9, 2026 12:26
dc18ae8 to
263d3d4
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
October 9, 2026 12:48
263d3d4 to
1d02742
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
October 9, 2026 13:09
1d02742 to
5579417
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-rename
branch
from
October 9, 2026 13:19
5579417 to
13c06a5
Compare
Contributor
|
| Changeset | Package |
|---|---|
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Theme renaming needs machine-readable outcomes.
WHAT is this pull request doing?
Add strict JSON theme resources with status and changed, computed from the original and resulting names. Retain cancellations and complete environment batches.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add