Repository navigation
Stabilize version, profile, and package cache tests - #8669
Merged
Merged
Conversation
gonzaloriestra
marked this pull request as ready for review
September 25, 2026 10:48
Suleimanlatrsh
approved these changes
Sep 25, 2026
gonzaloriestra
enabled auto-merge
September 28, 2026 08:21
3 of 4 tasks
Contributor
Author
|
@Shopify/developer-platforms can I get a review here, please? 🙏 |
This was referenced Sep 30, 2026
karreiro
approved these changes
Oct 2, 2026
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @gonzaloriestra!
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The Main tests workflow had 16 failed runs out of 112 from August 25 through September 25, 2026 (105 on
main, seven on stable branches). Repeated failures came from shared cache state, an unintended network request, and version subprocess timeouts on Windows.WHAT is this pull request doing?
Audit findings (counts overlap where a run had multiple failures):
The version subprocess tests were introduced in #8542, merged September 21. Earlier main-workflow logs show the old command test taking 16–25 ms; the new file takes 54–60 seconds on failing Windows runs. Local Node 22 profiling measured roughly 2.3 seconds importing the command through ts-node versus 33 ms executing it. A diagnostic invocation performed 1,638 compiler file reads and 5,295 file-existence checks. The replacement command assertions took 4–13 ms locally and use the default test timeout.
Exact output and schema checks remain in the required unit-test matrix. The version unit tests no longer assert child-process exit codes.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add