Repository navigation
Add typed JSON output to theme init - #8684
Open
gonzaloriestra wants to merge 6 commits into
Open
gonzaloriestra wants to merge 6 commits into
gonzaloriestra wants to merge 6 commits into
Conversation
gonzaloriestra
added this pull request to stack #8673
September 28, 2026 09:53
gonzaloriestra
marked this pull request as ready for review
September 28, 2026 10:17
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
September 28, 2026 11:39
15928b5 to
af38492
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
September 29, 2026 10:28
9c90616 to
a0861a7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
September 29, 2026 11:11
a0861a7 to
8b17788
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
September 29, 2026 13:44
1742d91 to
eced348
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
September 29, 2026 14:18
eced348 to
a5f5c9b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
September 29, 2026 14:40
a5f5c9b to
74e4949
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 1, 2026 08:52
74e4949 to
2c8e408
Compare
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:18
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 6, 2026 12:31
707b96f to
fb37427
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 8, 2026 08:43
4aa8c29 to
c2c97c3
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 8, 2026 09:53
c2c97c3 to
9b21f3d
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 10:04
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 9, 2026 12:26
39852ff to
2757cbd
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 9, 2026 12:48
2757cbd to
f8c3844
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 9, 2026 13:09
f8c3844 to
e4f59f1
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
October 9, 2026 14:01
ea75f3b to
e2f278b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 9, 2026 14:11
e2f278b to
4eb172b
Compare
Contributor
|
| Changeset | Package |
|---|---|
theme-check-json-contract.md |
'@shopify/cli': major |
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
theme-preview-json-contract.md |
'@shopify/cli': major |
theme-profile-environments.md |
'@shopify/cli': major |
theme-push-json-contract.md |
"@shopify/cli": major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,5 +11,12 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<Theme>;
+ create(themeRole?: Role, themeName?: string): Promise<{
+ createdAtRuntime: boolean;
+ id: number;
+ name: string;
+ processing: boolean;
+ role: string;
+ src?: string;
+ }>;
}
\ No newline at end of file
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Theme initialization needs structured outcomes that retain completed setup.
WHAT is this pull request doing?
Return an absolute project directory, instruction file paths and explicit success/partial outcomes. Keep a successfully cloned project when later AI setup fails, exit nonzero for partial work, and reject missing noninteractive names.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add