Repository navigation
Unhide shopify app security commands - #8742
nickwesselman wants to merge 4 commits into
Conversation
github-actions
Bot
added
shopify.dev preview
Area: @shopify/cli
|
/snapit |
|
🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm. Built from Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261002135905Caution After installing, validate the version by running |
Add check --list-files, render rerun commands from the selection and the typed scope flags, and record the scope on both sides so review can flag a mismatch. The instructions name the working directory and have the agent settle the scope before scanning. Cover the layout catalogue.
Run the real command with --without-app-config and --exclude, and check the results key, the selection, the recorded scope and the unresolved config checks. No other test scans with no app configuration file.
be9fe21 to
acaefc1
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
acaefc1 to
86f6d29
Compare
|
/snapit |
|
🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm. Built from Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261005160359Caution After installing, validate the version by running |
| test('is hidden and does not require linked app context', () => { | ||
| expect(SecurityCheck.hidden).toBe(true) | ||
| test('is visible and does not require linked app context', () => { | ||
| expect(SecurityCheck.hidden).toBeFalsy() |
There was a problem hiding this comment.
no need for these type of tests now that the command is public i guess
Visibility is already covered by the generated oclif manifest and the e2e command tree snapshot, so the unit tests no longer assert on `hidden`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
dmerand
left a comment
dmerand
left a comment
There was a problem hiding this comment.
Aside from Isaac's note, LGTM.
|
Superseded by #8766, the same change rebased onto Posted by Claude Code on behalf of the PR author. |
4 participants
WHY are these changes introduced?
The
shopify app securitycommands (check,clean,instructions,record,review) were hidden while in development. They're ready to be discoverable.WHAT is this pull request doing?
Removes
hidden = truefrom theapp securitycommands so they appear in help output, the CLI README, and shopify.dev docs. Regenerates the manifest, README, dev docs, and commands snapshot.How to manually test your changes?
pnpm shopify app --help—app securitycommands are listedpnpm shopify app security check --helpChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add🤖 Generated with Claude Code