Skip to content

Record created dev store identity on command events - #8761

Draft
dmerand wants to merge 1 commit into
mainfrom
donald/dev-store-creation-identity-20261002
Draft

dmerand wants to merge 1 commit into
mainfrom
donald/dev-store-creation-identity-20261002

Conversation

@dmerand

@dmerand dmerand commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Existing command events need the native identity of the dev store they create. A readiness or App refetch failure must not lose that identity once creation returns a store.

Related context: #8389. JSON error reporting is a separate change.

WHAT is this pull request doing?

Select the existing shopifyShopId in the creation mutation and record it as the existing numeric public store_id before readiness polling. The shared creator covers store create dev and both inline app dev creation routes. Missing or invalid IDs skip the metadata write without extra requests.

Prompts, human/JSON output, errors, polling, domain metadata, and delete behavior stay unchanged. No creation marker or new event is added.

How to manually test your changes?

  • Local-only option: use a debugger with mocked creation responses. Check public metadata before the first readiness poll. A valid native ID produces numeric store_id; a missing or invalid ID does not. A later poll failure retains the valid ID.
  • With an authorized disposable test account, use shopify store create dev and shopify app dev. For App, create a store from an empty store list and from the store picker. Inspect the existing command-event payload for the created shop's numeric store_id. Confirm prompts and output stay the same, then stop App dev and remove the disposable resources.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Oct 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant