Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Existing command events need the native identity of the dev store they create. A readiness or App refetch failure must not lose that identity once creation returns a store.
Related context: #8389. JSON error reporting is a separate change.
WHAT is this pull request doing?
Select the existing
shopifyShopIdin the creation mutation and record it as the existing numeric publicstore_idbefore readiness polling. The shared creator coversstore create devand both inlineapp devcreation routes. Missing or invalid IDs skip the metadata write without extra requests.Prompts, human/JSON output, errors, polling, domain metadata, and delete behavior stay unchanged. No creation marker or new event is added.
How to manually test your changes?
store_id; a missing or invalid ID does not. A later poll failure retains the valid ID.shopify store create devandshopify app dev. For App, create a store from an empty store list and from the store picker. Inspect the existing command-event payload for the created shop's numericstore_id. Confirm prompts and output stay the same, then stop App dev and remove the disposable resources.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add