Repository navigation
Allow app security instructions before results exist - #8808
Merged
Merged
Conversation
jplhomer
approved these changes
Oct 6, 2026
dmerand
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
shopify app security instructionsaborts in a fresh app because it requires a results directory, even though the generated standalone workflow starts by runningshopify app security check. This prevents the instructions from initiating the workflow they describe.WHAT is this pull request doing?
Removes the results-directory precondition from
instructionsand verifies that instructions are delivered before any check results exist.record,review, andcleankeep their existing results checks.Known trade-off:
instructionsdoes not validate--client-id; the generatedcheckcommand validates it when run.How to manually test your changes?
shopify.app.tomland no.shopify/app-security/directory.pnpm shopify app security instructions --path <app>.### 1. Run the scan.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add