Repository navigation
Add typed JSON output to theme delete - #8913
Merged
gonzaloriestra merged 8 commits intoOct 16, 2026
Merged
Conversation
gonzaloriestra
added this pull request to stack #8925
October 15, 2026 12:34
gonzaloriestra
marked this pull request as ready for review
October 15, 2026 12:42
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
October 15, 2026 13:33
58f6b73 to
892518a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-delete
branch
from
October 15, 2026 13:52
892518a to
ea1e9e9
Compare
isaacroldan
approved these changes
Oct 15, 2026
Contributor
|
| Changeset | Package |
|---|---|
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -1,4 +1,5 @@
import { type JsonOutputSchema } from './json-output-schema.js';
+import { JsonMap } from '../../private/common/json.js';
import { Command } from '@oclif/core';
import { OutputFlags, Input, ParserOutput, FlagInput, OutputArgs } from '@oclif/core/parser';
export type ArgOutput = OutputArgs<any>;
@@ -35,6 +36,8 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected parseEnvironmentFlags<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(environment: JsonMap, options: Input<TFlags, TGlobalFlags, TArgs>, explicitFlags: FlagOutput): Promise<FlagOutput>;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
karreiro
approved these changes
Oct 15, 2026
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @gonzaloriestra!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR and review history: #8651.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/23692
Theme deletion needs machine-readable outcomes without losing successful deletions.
WHAT is this pull request doing?
Separate service data from presentation and add strict JSON results, cancellation objects and complete environment batches. Preserve successful deletions and item errors when deletion partly fails.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add