Repository navigation
Add typed JSON output to theme profile - #8921
Merged
gonzaloriestra merged 4 commits intoOct 19, 2026
Merged
Conversation
gonzaloriestra
added this pull request to stack #8925
October 15, 2026 12:34
gonzaloriestra
marked this pull request as ready for review
October 15, 2026 12:42
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 15, 2026 13:33
6e6f4cb to
d343c53
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
2 times, most recently
from
October 15, 2026 14:10
87b3289 to
629bdc4
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 15, 2026 14:33
629bdc4 to
40184df
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 15, 2026 15:11
40184df to
37eeacb
Compare
isaacroldan
reviewed
Oct 15, 2026
isaacroldan
left a comment
Contributor
There was a problem hiding this comment.
These tests should not change the saved CLI store.
🤖 Generated by the review-pr skill
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
2 times, most recently
from
October 16, 2026 08:15
1e3bfa7 to
c1a1834
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 16, 2026 08:40
c1a1834 to
3c6fd1c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 16, 2026 10:37
3c6fd1c to
9276719
Compare
isaacroldan
reviewed
Oct 16, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 16, 2026 11:08
9276719 to
d3ee84c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 16, 2026 11:15
d3ee84c to
9ac5a7f
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 16, 2026 11:32
9ac5a7f to
e44ef94
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 16, 2026 14:20
e44ef94 to
3415c09
Compare
karreiro
approved these changes
Oct 19, 2026
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @gonzaloriestra!
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 19, 2026 08:44
3415c09 to
ba40812
Compare
isaacroldan
approved these changes
Oct 19, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Oct 19, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-profile
branch
from
October 19, 2026 11:02
ba40812 to
04883cc
Compare
Contributor
|
| Changeset | Package |
|---|---|
theme-check-json-contract.md |
'@shopify/cli': major |
theme-profile-environments.md |
'@shopify/cli': major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -21,6 +21,7 @@ declare abstract class BaseCommand extends Command {
static descriptionWithoutMarkdown(): string | undefined;
static analyticsNameOverride(): string | undefined;
static analyticsStopCommand(): string | undefined;
+ private jsonOutputFromFlags;
catch(error: Error & {
skipOclifErrorHandling: boolean;
}): Promise<void>;
@@ -36,6 +37,7 @@ declare abstract class BaseCommand extends Command {
}, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options?: Input<TFlags, TGlobalFlags, TArgs>, argv?: string[]): Promise<ParserOutput<TFlags, TGlobalFlags, TArgs> & {
argv: string[];
}>;
+ protected runWithParsedOutput<T>(flags: FlagOutput, execute: () => T): T;
protected environmentsFilename(): string | undefined;
protected parseEnvironmentFlags<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(environment: JsonMap, options: Input<TFlags, TGlobalFlags, TArgs>, explicitFlags: FlagOutput): Promise<FlagOutput>;
protected validateNonTTYFlags(flags: FlagOutput): void;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR and review history: #8643.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/23691
Explicit theme profiling environments need the same ordered batch contract.
WHAT is this pull request doing?
Preserve the native Speedscope artifact and wrap explicitly named environments in one result object. Separate service data from presentation and keep failures on the shared fatal path.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add