Repository navigation
Add typed JSON output to autocorrect off - #8933
Conversation
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,12 +11,5 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<{
- createdAtRuntime: boolean;
- id: number;
- name: string;
- processing: boolean;
- role: string;
- src?: string;
- }>;
+ create(themeRole?: Role, themeName?: string): Promise<Theme>;
}
\ No newline at end of file
|
7bd745d to
e614504
Compare
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Built from Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261019103528Caution After installing, validate the version by running |
713f0b2 to
67ae652
Compare
karreiro
left a comment
There was a problem hiding this comment.
Thank you, @gonzaloriestra!
67ae652 to
c2126a1
Compare
c2126a1 to
f9b7296
Compare
WHY are these changes introduced?
config autocorrect offcannot return the saved preference as a typed JSON result.Fixes https://github.com/shop/issues-develop/issues/24282.
WHAT is this pull request doing?
Add
--jsonusing the shared autocorrect result schema and presenter. Return{enabled: false}after saving the preference, preserve the terminal message, and refresh the migration exceptions, manifest, and generated documentation. Extend the command contract tests to cover disabling autocorrect.How to manually test your changes?
pnpm shopify config autocorrect status.pnpm shopify config autocorrect off --json --no-inputand check for{"enabled": false}.pnpm shopify config autocorrect status --jsonto confirm the preference was saved, then restore the original setting with the correspondingonoroffcommand.Checklist