Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Disco] Tweak main-search layout to better display Search Result page errors #3589

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Draft

[Disco] Tweak main-search layout to better display Search Result page errors #3589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions sections/main-search.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@
}
{%- endstyle -%}

{% paginate search.results by 24 %}
<div class="template-search{% unless search.performed and search.results_count > 0 %} template-search--empty{% endunless %} section-{{ section.id }}-padding">
<div class="template-search__header page-width{% if settings.animations_reveal_on_scroll %} scroll-trigger animate--fade-in{% endif %}">
<div class="page-width template-search{% unless search.performed and search.results_count > 0 %} template-search--empty{% endunless %} section-{{ section.id }}-padding">
{% paginate search.results by 24 %}
<div class="template-search__header {% if settings.animations_reveal_on_scroll %} scroll-trigger animate--fade-in{% endif %}">
<h1 class="h2 center">
{%- if search.performed -%}
{{- 'templates.search.title' | t -}}
Expand Down Expand Up @@ -254,7 +254,7 @@
class="grid product-grid grid--{{ section.settings.columns_mobile }}-col-tablet-down grid--{{ section.settings.columns_desktop }}-col-desktop"
role="list"
>
{%- assign skip_card_product_styles = false -%}

Check warning on line 257 in sections/main-search.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/main-search.liquid#L257 

[LiquidTag] Use {% liquid ... %} to write multiple tags
{%- for item in search.results -%}
{% assign lazy_load = false %}
{%- if forloop.index > 2 -%}
Expand Down Expand Up @@ -325,8 +325,9 @@
</div>
</div>
{%- endif -%}
</div>
{% endpaginate %}
{% endpaginate %}
</div>

{% if section.settings.image_shape == 'arch' %}
{% render 'mask-arch' %}
{%- endif -%}
Expand Down
Loading