feat: add interruption adapter for shoryuken#722
Conversation
luizlevindiniz
force-pushed
the
feature/support-shoryuken
branch
from
638da27 to
0106bd1
Compare
|
I have signed the CLA! |
Mangara
left a comment
Mangara
left a comment
There was a problem hiding this comment.
Thanks for adding this! One question, otherwise LGTM.
| gem "shoryuken" | ||
| gem "aws-sdk-sqs" |
There was a problem hiding this comment.
We don't actually have integration tests against these gems. Do they need to be here?
There was a problem hiding this comment.
Good question.
Aws-sdk-sqs seems to be unnecessary here, so I have just removed it in a new commit.
Regarding shoryuken, removing it fails InterruptionAdaptersTest#test_loads_all_available_interruption_adapters(test/integration/interruption_adapters_test.rb). If you prefer, I can add shoryuken to the adapters_to_exclude array in this same file.
There was a problem hiding this comment.
We can test both approaches. In fact, I have just remembered that I have excluded aws-sdk-sqs from the gemfile in a previous commit, but it was causing some errors in the ci (https://github.com/Shopify/job-iteration/actions/runs/27232224197/job/80415276217)
luizlevindiniz
force-pushed
the
feature/support-shoryuken
branch
from
0106bd1 to
b8a1c3c
Compare
3 participants
close: #719
This PR adds an interruption adapter for shoryuken