Raise SyntaxError on invalid UTF8 strings in lexer/tokenizer #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Thank you for this PR, @catlee! I believe this change is in the right direction.
Part of me feels we should raise the error with the Unexpected character message, to be cohesive with the raise_syntax_error method. But, given we were raising an ArgumentError, I believe it's fine to have a more specific message for this.
Thanks again for this PR!
catlee
force-pushed
the
catlee/invalid_utf8
branch
from
f99a495 to
550135c
Compare
karreiro
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.