Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escape_once not working with hex entities or named entities endin… #793

Closed
wants to merge 1 commit into from
Closed

Conversation

kainjow
Copy link
Contributor

@kainjow kainjow commented Aug 28, 2016

…g with numbers

Fixes #792

@fw42
Copy link
Contributor

fw42 commented Aug 29, 2016

Thanks for your contribution! This makes sense to me.

@gauravmc, mind taking a quick look?

@kainjow
Copy link
Contributor Author

kainjow commented Aug 29, 2016

I just noticed two issues actually:

  • The 'x' for hex entities can be uppercased (just tested briefly with Safari/Chrome/Firefox)
  • The hex characters is wrong, it should be stricter [\da-fA-F]

Let me go back and fix these. I'll open a new pull request.

@kainjow kainjow closed this Aug 29, 2016
@kainjow kainjow deleted the escape_once branch August 31, 2016 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants