Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix filenames with rbs_ #31

Open
wants to merge 5 commits into
base: c-api
Choose a base branch
from
Open

Prefix filenames with rbs_ #31

wants to merge 5 commits into from

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Mar 28, 2025

Most of the header/source files are now prefixed with rbs_, so @amomchilov and I think it'd better to have them all prefixed that way too.

@st0012 st0012 requested review from Morriar and amomchilov March 28, 2025 22:03
@st0012
Copy link
Member Author

st0012 commented Mar 31, 2025

In fact, cpp shouldn't have any conflicts based on just file names, which I've verified through a small experiment:

I have both rbs/util/rbs_assert.h and rbs/rbs_assert.h

#ifndef RBS_ASSERT_H
#define RBS_ASSERT_H

#include "rbs/rbs_defines.h"
#include <stdbool.h>

void rbs_assert(bool condition, const char *fmt, ...) RBS_ATTRIBUTE_FORMAT(2, 3);

#endif
#ifndef RBS_ROOT_ASSERT_H
#define RBS_ROOT_ASSERT_H

#include "rbs/rbs_defines.h"
#include <stdbool.h>

void rbs_assert_2(bool condition, const char *fmt, ...) RBS_ATTRIBUTE_FORMAT(2, 3);

#endif

And include both of them:

#include "rbs/rbs_encoding.h"
#include "rbs/rbs_assert.h"
#include "rbs/util/rbs_assert.h"

And it compiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants