Handle rbs_node and rbs_node_list types #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
approved these changes
Nov 20, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Just a point about the type method name, but otherwise it looks good
rust/ruby-rbs/build.rs
Outdated
| } | ||
| "rbs_node" => { | ||
| let (function_name, field_name) = match field.name.as_str() { | ||
| "type" => ("r#type", "type_"), |
Member
There was a problem hiding this comment.
Does this mean that the method will be created with the name type? If so, I'd vote for us to use type_.
Since type is a reserved keyword, invoking the method might prove a little odd, especially if we end up having to use the raw identifier syntax (r#type()).
Author
There was a problem hiding this comment.
We would have to use the raw indentifier syntax. I agree it's odd.
I'll change it to type_ like bindgen does
st0012
approved these changes
Nov 20, 2025
This adds support for `rbs_node` and `rbs_node_list` field types in the bindings generator. This enables access to child nodes and node lists from parent AST nodes. We handle fields named `type` (which is a Rust keyword) by escaping the accessor method to `r#type()` and correctly mapping to the underlying `type_` field in the C struct.
alexcrocha
force-pushed
the
11-19-handle_rbs_node_and_rbs_node_list_types
branch
from
3d63b58 to
245bf8d
Compare
alexcrocha
added a commit
that referenced
this pull request
Jan 13, 2026
Enable nested AST traversal by exposing rbs_node and rbs_node_list fields Nested structure traversal (e.g., class members, constant types) depends on access to rbs_node and rbs_node_list fields. Making these fields accessible aligns the Rust bindings with the C API. Fields named "type" are accessible via type_ to avoid a Rust keyword collision
alexcrocha
added a commit
that referenced
this pull request
Jan 13, 2026
Enable nested AST traversal by exposing rbs_node and rbs_node_list fields Nested structure traversal (e.g., class members, constant types) depends on access to rbs_node and rbs_node_list fields. Making these fields accessible aligns the Rust bindings with the C API. Fields named "type" are accessible via type_ to avoid a Rust keyword collision
alexcrocha
added a commit
that referenced
this pull request
Jan 14, 2026
Enable nested AST traversal by exposing rbs_node and rbs_node_list fields Nested structure traversal (e.g., class members, constant types) depends on access to rbs_node and rbs_node_list fields. Making these fields accessible aligns the Rust bindings with the C API. Fields named "type" are accessible via type_ to avoid a Rust keyword collision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for
rbs_nodeandrbs_node_listfield types, which were missed in the initial Node/NodeList implementation (#57).Changes:
rbs_nodeandrbs_node_listinbuild.rs.typeby escaping the accessor tor#type()and mapping to the underlyingtype_C field.NodeListconstructor to work with the generated accessors.This enables traversal of nested AST structures (e.g. accessing a class's members or a constant's type) which was previously not possible through the bindings.