Use NonNull wrapper for parser pointers #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
approved these changes
Jan 13, 2026
alexcrocha
force-pushed
the
01-13-use_nonnull_wrapper_for_parser_pointers
branch
from
c45afcd to
352d9c4
Compare
alexcrocha
force-pushed
the
01-13-add_lifetimes
branch
from
33d9ae5 to
b9b6d4a
Compare
alexcrocha
force-pushed
the
01-13-use_nonnull_wrapper_for_parser_pointers
branch
from
352d9c4 to
afe79b0
Compare
alexcrocha
added a commit
that referenced
this pull request
Jan 14, 2026
Replaced `*mut T` with `NonNull<T>` for the parser pointer to make the ‘never null’ assumption explicit. `NonNull<T>` represents a non-null raw pointer (a wrapper around `*mut T`) that guarantees the pointer is never null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
*mut TwithNonNull<T>for the parser pointer to make the ‘never null’ assumption explicit.NonNull<T>represents a non-null raw pointer (a wrapper around*mut T) that guarantees the pointer is never null.