Prevent set state when disabled #150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhkaplan
force-pushed
the
prevent-setState-when-disabled
branch
from
fd7e64b to
e01d705
Compare
ken0nek
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This way, we can use ReactNavigationPerformanceView in production just like PerformanceMeasureView without worrying about degrading performance
Description
It looks like the setState call would result in a re-render, which is best avoided when disabled. Please tell me if you prefer a different approach 🙏
I also updated part of the contribution guidelines
Test plan
Added unit test
Checklist
I have added a decision record entry, PR includes changes to monorepo setup that may require explanation