Tag log messages with originating stream#903
Open
LasmarKhalifa wants to merge 1 commit into
Open
Conversation
LasmarKhalifa
force-pushed
the
05-28/log-message-prototype
branch
2 times, most recently
from
13e8de8 to
94f6242
Compare
dersam
reviewed
Jun 2, 2026
LasmarKhalifa
force-pushed
the
05-28/log-message-prototype
branch
from
94f6242 to
ceb0bf3
Compare
LasmarKhalifa
force-pushed
the
05-28/log-message-prototype
branch
from
ceb0bf3 to
f8c1a2a
Compare
dersam
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #909
Refactors the log messages with a
typeattribute so that LogFormatter#colourize becomes more robust and tests assess the colourize method properly.Adds .to_s to CustomLogging because we previously only had strings as messages, but we now have either a string or a Roast::Log::Message, so we need to normalize using .to_s so that we output only the text of the message rather than the entire object.