Skip to content

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented May 29, 2025

Motivation

This PR is attempt to speed up launching the server by doing two things:

  1. Moving the server update to after we finished booting. The update operation is very slow on large bundles, so if we can avoid doing it in the main launch path, we can boot significantly faster
  2. Using bundle check and only running bundle install if absolutely necessary, which is also a bit faster

Moving the update after the server launches also reduces the surface area for Bundler issues to accidentally block booting the server.

Implementation

There are two commits:

  1. Move the update to after the server launched
  2. Started running bundle check and then only bundle installing when necessary

Note that this only impacts launcher mode.

Automated Tests

Updated our existing tests.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock force-pushed the 05-26-update_after_launching_the_server branch from 54e9cb0 to 315b235 Compare May 29, 2025 14:56
@vinistock vinistock self-assigned this May 29, 2025
@vinistock vinistock added server This pull request should be included in the server gem's release notes enhancement New feature or request labels May 29, 2025 — with Graphite App
@vinistock vinistock marked this pull request as ready for review May 29, 2025 14:57
@vinistock vinistock requested a review from a team as a code owner May 29, 2025 14:57
@vinistock vinistock force-pushed the 05-26-update_after_launching_the_server branch 2 times, most recently from 76e5173 to 2ec40a1 Compare May 29, 2025 17:50
@vinistock vinistock force-pushed the 05-26-update_after_launching_the_server branch 5 times, most recently from 20b76d6 to 06311ef Compare May 31, 2025 21:12
@vinistock vinistock force-pushed the 05-26-update_after_launching_the_server branch from 06311ef to f3c6aab Compare June 26, 2025 14:03
@vinistock vinistock enabled auto-merge (squash) June 26, 2025 14:03
@vinistock vinistock merged commit c50572c into main Jun 26, 2025
37 checks passed
@vinistock vinistock deleted the 05-26-update_after_launching_the_server branch June 26, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants