add support for detecting extra fields in fixtures#27
Closed
lopert wants to merge 2 commits into
Closed
Conversation
lopert
force-pushed
the
lopert.extra-fixture-data
branch
from
3ad1622 to
d1019c2
Compare
adampetro
reviewed
Oct 20, 2025
Contributor
adampetro
left a comment
adampetro
left a comment
There was a problem hiding this comment.
Does this handle abstract types? I think we might need a different approach to handle the case of abstract types with selections that vary depending on which concrete type is present
lopert
force-pushed
the
lopert.extra-fixture-data
branch
from
d1019c2 to
ec77240
Compare
lopert
force-pushed
the
lopert.extra-fixture-data
branch
from
ec77240 to
d771a87
Compare
lopert
force-pushed
the
lopert.extra-fixture-data
branch
from
d771a87 to
0a918b2
Compare
lopert
force-pushed
the
lopert.abstract-types
branch
from
6e2bb1c to
84542dd
Compare
Collaborator
Author
|
Closed in favour of #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detects extra fields by keeping track of expectedFields (aka the ones we've visited) in a new stack, parallel to the existing valueStack. Then when leaving a node with a selection set, compare what's available in the fixture to the visited field names to find extras.