Adding CI to repo#32
Conversation
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| package-lock.json |
There was a problem hiding this comment.
Added this here so if someone accidentally uses npm instead of pnpm for building, they dont end up pushing a package-lock.json file.
saga-dasgupta
force-pushed
the
sd.run_ci
branch
from
9e9b701 to
06aaf6f
Compare
| environment: "node", | ||
| include: [ | ||
| "test/**/*.test.ts", | ||
| "test-app/extensions/*/tests/**/*.test.js", |
There was a problem hiding this comment.
wasm-testing-helpers-test.ts is no longer needed because the tests from test-app extensions are directly included here.
saga-dasgupta
force-pushed
the
sd.run_ci
branch
4 times, most recently
from
e1cc338 to
de6287e
Compare
| all-checks-pass: | ||
| name: 'All Checks Pass' | ||
| if: always() | ||
| needs: [lint-and-typecheck, test, build, integration-tests] | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check all jobs | ||
| run: | | ||
| if [[ "${{ needs.lint-and-typecheck.result }}" != "success" ]] || \ | ||
| [[ "${{ needs.test.result }}" != "success" ]] || \ | ||
| [[ "${{ needs.build.result }}" != "success" ]] || \ | ||
| [[ "${{ needs.integration-tests.result }}" != "success" ]]; then | ||
| echo "One or more checks failed" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
This acts as a single status check that waits for all jobs to complete and fails if any didn't succeed. Its for making branch protection rules easier when we have multiple parallel jobs like lint, tests (6 jobs: 3 OS × 2 Node versions), integration-tests. We can just add this one check for branch protection instead of all the 8 different checks.
saga-dasgupta
force-pushed
the
sd.run_ci
branch
from
bf618b6 to
1ed4f12
Compare
adampetro
left a comment
adampetro
left a comment
There was a problem hiding this comment.
We should gitignore the target directory of the Rust example
saga-dasgupta
force-pushed
the
sd.run_ci
branch
from
1ed4f12 to
a4b5277
Compare
saga-dasgupta
force-pushed
the
sd.run_ci
branch
from
1d264ce to
21f28d0
Compare
lopert
left a comment
lopert
left a comment
There was a problem hiding this comment.
Looks like the target dir ended up in the PR during one of the renames, in this commit. I see Adam and you have a thread about it so I'll defer to that.
…le and adding test-app tests in the vitest config, renaming discount-function to discount-function-rs, adding separate step for integration test in CI
…se it should get installed in the previous step
…repo without getFunctionInfo
saga-dasgupta
force-pushed
the
sd.run_ci
branch
from
4963540 to
80ed8e8
Compare
3 participants
Broke this change into 3 commits:
test-apptests directly to the vitest config sonpm testsimply runs it, renamesdiscount-functionintest-apptodiscount-function-rsbecause we havecart-validation-jsas the other function and finally also updates theREADME.Probably easiest to review commit by commit and with whitespace changes turned off
?w=1at the end of the url.You can see the CI runs added and running in this PR for tests and linting.