Configure publishing workflow#34
Merged
Merged
Conversation
saga-dasgupta
approved these changes
Nov 4, 2025
Contributor
saga-dasgupta
left a comment
There was a problem hiding this comment.
Lines up with the instructions on the vault page.
| "lint": "eslint src/ test/", | ||
| "lint:fix": "eslint src/ test/ --fix", | ||
| "prepublishOnly": "pnpm run build && pnpm run test && pnpm run lint" | ||
| "prepublishOnly": "pnpm run build && pnpm run test && pnpm run lint", |
Contributor
There was a problem hiding this comment.
In the README I have all commands as pnpm build, pnpm test etc, should we keep it that way here as well?
Collaborator
Author
There was a problem hiding this comment.
I think either way is fine. In our CI.yml workflow, it uses the run variants, so I'll keep this one here with it as well for consistency.
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20.x' |
Contributor
There was a problem hiding this comment.
Should we also make this env variable up top for better visibility?
Collaborator
Author
There was a problem hiding this comment.
Good call. I think it's worth having split out since we will want to easily find it when it comes to updating things to stay consistent with what the CLI expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up the release workflow as per our docs.
This is the first step of the following flow: