Fix CI in a better way#972
Merged
Merged
Conversation
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
paracycle
approved these changes
Jun 6, 2022
vinistock
approved these changes
Jun 7, 2022
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
We may want to stop pointing at the branches when the gems are released. Should we add a todo?
Contributor
Author
Since it's only development dependencies I'm not too worried. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The upstream fixes about
Railtiehave been merged:Railtieintegration ifRails::Railtieis defined rubyconfig/config#319Railtieintegration ifRails::Railtieis defined byroot/frozen_record#52We can now revert the temporary fix from #965.
Tests
CI is green 💚