Add avatar 2025rc #3003
Add avatar 2025rc #3003
Conversation
| language: 'tsx', | ||
| }, | ||
| { | ||
| title: 'JS', |
There was a problem hiding this comment.
Don't we only do Preact examples now? Can we remove the JS one?
There was a problem hiding this comment.
It seems like the JS examples still exist for the other components but are just not displayed on the documentation. I decided to follow that and keep the file but remove it from the documentation.
There was a problem hiding this comment.
Sorry for not catching these all at once - but I still see the JS example on the docs. I think you need to remove the reference to it from this file
| * | ||
| * @default 'base' | ||
| */ | ||
| size?: Extract<Size, 'base' | 'large' | 'extraLarge' | 'fill'>; |
There was a problem hiding this comment.
I noticed that the size prop does not have as much information in the RC docs as it does in the previous version. Left is old right is new:
I am not 100% sure what the fix is here because you have the right content here. Maybe we need to import the Size prop in this file?
There was a problem hiding this comment.
I managed to fix this and it should now be working.
Here is a screenshot of the resolved issue:
Feel free to test it out yourself, and please let me know if any other adjustments need to be made 🙂
There was a problem hiding this comment.
Nice! I think you might have forgotten to push the change for this PR 😅 I dont see any changes since the last review on here
There was a problem hiding this comment.
Oops sorry, I only pushed the shopify-dev commit, the ui-extensions one should be up to date now 🙂
SHAZAM28
force-pushed
the
add-avatar-2025rc
branch
from
32eba21 to
ac419c8
Compare
| export type Size = | ||
| | 'extraSmall' | ||
| | 'small' | ||
| | 'base' | ||
| | 'large' | ||
| | 'extraLarge' | ||
| | 'fill'; |
There was a problem hiding this comment.
I tried it out, and I think you should be able to import this from the shared file instead at the top of the file:
import {Size} from './components/shared';There was a problem hiding this comment.
Alright I'll try again and see if that works
There was a problem hiding this comment.
done, change have been pushed
SHAZAM28
force-pushed
the
add-avatar-2025rc
branch
from
0400758 to
797c859
Compare
Description
Original issue: https://github.com/shop/issues-checkout/issues/5645
Create and add Avatar Component to Documentation
What's Changed
This PR introduces a new Avatar component for the Customer Account surface, making it easier for developers to display user profile images in their UI extensions.
📝 Changes Made Added Avatar component with TypeScript definitions and proper integration into the component system
📚 Documentation Updates
Screenshot of working document: