Conversation
Adds a default quality profile picker to each Radarr/Sonarr instance's edit form in /admin/settings. When set, it is preselected in every quick-add / suggested-add and library add flow instead of whichever profile the service happens to return first; null keeps the previous behaviour, so existing installs are unaffected. Stored per ServiceInstance (profile ids aren't shared across instances) via a new nullable default_quality_profile_id column + migration (auto-applies on boot). Threaded through ServiceInstanceProvider create/update. Consumed by: the global quick-add modal (via the resolve candidates payload), the films library modal (via /films/config), the series library modal (via the rendered instance), plus a server-side fallback in filmAdd/seriesAdd so programmatic/degraded adds honor it too. Full suite green (1117); provider round-trip + candidate-exposure covered. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5.
Implements the plan you outlined on the issue — "a default quality profile picker per service in
/admin/settings, applied to all quick-add and suggested-add flows. Falls back to the current behaviour when not set, so existing installs aren't affected."What changes
/admin/settingsgains a "Default quality profile" picker. Its options are loaded live from that instance's own Radarr/Sonarr when the modal opens (with the stored value rendered as a fallback option so it round-trips even if the fetch fails)./films/add,/series/add) that don't specify a profile.Per-instance, not per-service-type
I stored the default per
ServiceInstancerather than per service type: quality-profile ids aren't shared across instances (profile3on "Radarr 1080p" is a different profile from3on "Radarr 4K"), so a single per-type default would be meaningless with multiple instances. It's a new nullabledefault_quality_profile_idcolumn with a migration (auto-applies on boot; null default = existing behaviour). The picker still lives in/admin/settingsvia the instance edit modal, matching your intent.Includes provider round-trip tests and a candidate-exposure test; full suite green. EN + FR labels added. Shipped and verified live on my fork (admin picker loads real profiles, default persists, and both the global quick-add and library add modals preselect it).