Skip to content

fix(qbittorrent): guard against stale pagination responses #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeromelefeuvre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(qbittorrent): guard against stale pagination responses #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions symfony/templates/qbittorrent/index.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1212,10 +1212,17 @@ body[data-bs-theme="dark"] .qbt-torrent-list[data-view="table"] .qbt-cell-progre
});

var refreshCtrl = null;
var refreshSeq = 0;
function refreshData() {
// Annule le fetch précédent s'il est encore en vol (évite empilement)
if (refreshCtrl) refreshCtrl.abort();
refreshCtrl = new AbortController();
// abort() n'a aucun effet si la réponse précédente est déjà arrivée
// (fréquent en local, où le round-trip peut être plus rapide que le
// délai clic → exécution JS) : sans ce numéro de séquence, une réponse
// de sondage périodique pour l'ancienne page peut s'appliquer APRÈS
// celle du clic sur une autre page, et y revenir juste après l'affichage.
var seq = ++refreshSeq;
var q = new URLSearchParams({
page: pagState.page,
perPage: pagState.perPage,
Expand All @@ -1229,6 +1236,7 @@ body[data-bs-theme="dark"] .qbt-torrent-list[data-view="table"] .qbt-cell-progre
fetch(BASE + '/api/torrents?' + q, { signal: refreshCtrl.signal, headers: { 'X-Requested-With': 'XMLHttpRequest' } })
.then(function(r) { return r.json(); })
.then(function(data) {
if (seq !== refreshSeq) return; // une requête plus récente a déjà été émise
if (data.error) return;
updateStats(data.stats);
updateList(data.torrents);
Expand Down