fix(transmission): request rateDownload/rateUpload for the detail panel - #98
Open
ndandan wants to merge 2 commits into
Open
fix(transmission): request rateDownload/rateUpload for the detail panel#98ndandan wants to merge 2 commits into
ndandan wants to merge 2 commits into
Conversation
getTorrentDetail() read $t['rateDownload']/$t['rateUpload'] for properties.dl_speed/up_speed, but DETAIL_FIELDS never asked Transmission's torrent-get RPC for either field — since Transmission only returns requested fields, both always coalesced to 0 and the detail modal's General tab showed 0 B/s regardless of actual speed. Add a reflection-based test asserting DETAIL_FIELDS contains every field getTorrentDetail() reads off the torrent object. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTorrentDetail()readsrateDownload/rateUploadoff the torrent object to populate the detail modal's General-tab speeds, but thetorrent-getRPC field list (DETAIL_FIELDS) never requested either field. Transmission only returns fields that were explicitly asked for, so both always coalesced to0— the detail panel showed 0 B/s regardless of actual transfer speed.Both fields are now included in
DETAIL_FIELDS. A reflection-based test asserts the list contains every fieldgetTorrentDetail()reads off the torrent object, so this class of omission can't silently regress.