Interactive search: link release titles to their tracker page - #99
Open
ndandan wants to merge 2 commits into
Open
Interactive search: link release titles to their tracker page#99ndandan wants to merge 2 commits into
ndandan wants to merge 2 commits into
Conversation
…page (infoUrl) — upstream Shoshuo#35 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
infoUrl is passed through verbatim from the Radarr/Sonarr release payload, which is in turn sourced from whatever indexer answered the interactive search. A hostile/compromised indexer could return a javascript:/data: URL, which would previously reach the frontend unfiltered and land in the anchor's href. Sanitize once, at the controller mapping (single testable choke point), rather than relying on the fork's CSP — this commit becomes an upstream PR where that CSP does not exist. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35.
Radarr/Sonarr already return an
infoUrlper release; the release mappers just dropped it. This PR:infoUrlin all three interactive-search endpoints (film / episode / season) through a smallsafeInfoUrl()allowlist — onlyhttp(s)://URLs are emitted, anything else (includingjavascript:/data:from a hostile indexer) maps tonull;<a href target="_blank" rel="noopener">in both release tables when aninfoUrlis present, plain text otherwise. The rejection marker stays outside the link.Tests:
MediaReleasesSearchTestgains mapping tests for all three endpoints (URL kept, missing key → null,javascript:→ null, uppercaseHTTPS://kept, non-string → null). 7 tests / 24 assertions green,lint:twigclean.🤖 Generated with Claude Code