Use @flow-weak to avoid errors in Flow 0.14#17
Open
dbrock wants to merge 2 commits intoShuangzuan:masterfrom
Open
Use @flow-weak to avoid errors in Flow 0.14#17dbrock wants to merge 2 commits intoShuangzuan:masterfrom
dbrock wants to merge 2 commits intoShuangzuan:masterfrom
Conversation
Here are the errors in case someone prefers to fix them (I didn't know what to do about the "Computed property cannot be assigned with possibly undefined value" ones): ``` node_modules/react-refresh-control/RCTRefreshControl.ios.js:30:23,29: parameter configs Missing annotation node_modules/react-refresh-control/RCTRefreshControl.ios.js:30:32,39: parameter callback Missing annotation node_modules/react-refresh-control/RCTRefreshControl.ios.js:31:22,55: call of method findNodeHandle Error: node_modules/react-refresh-control/RCTRefreshControl.ios.js:39:9,40: assignment of computed property/element Computed property cannot be assigned with possibly null value node_modules/react-refresh-control/RCTRefreshControl.ios.js:31:22,55: null node_modules/react-refresh-control/RCTRefreshControl.ios.js:31:22,55: call of method findNodeHandle Error: node_modules/react-refresh-control/RCTRefreshControl.ios.js:39:9,40: assignment of computed property/element Computed property cannot be assigned with possibly undefined value node_modules/react-refresh-control/RCTRefreshControl.ios.js:31:22,55: undefined node_modules/react-refresh-control/RCTRefreshControl.ios.js:43:27,30: parameter node Missing annotation Found 5 errors ```
Author
|
Oops, I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm attaching the errors below in case someone prefers to actually fix them instead. I didn't know what to do about the "Computed property cannot be assigned with possibly null/undefined value" ones, in particular.