-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): add telegram alert channel #5411
Conversation
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
@Ellipse0934 great progress 🎉 |
On the one hand its "almost" done, I can successfully add a telegram channel and receive messages. Currently no message templating is exposed to the user but its a good feature to have regardless. So I think it's better to have a template defined with the deceiver so the user can set it. We can possibly defer this for another PR if you want or we can start here. I did accidentally break something, It was working. But now I only get a notification when I change/save the config. Subsequent alerts are sent from query-service to alertmanager but something is failing and the failure is silent. In a way its good because it may likely point to a fragile part and save someone trouble in the future. There is also the issue of HTML escape. It's not being done correctly. I need to fix this on the alertmanager PR. |
Let me know if you need any help reviewing. You'll need to create a telegram bot. Instructions for that can be found here: https://core.telegram.org/bots/tutorial |
guys can't wait hearings from you @YounixM , @srikanthccv ! Telegram integration doesn't work for newcomer as me |
This missed my radar. @Ellipse0934 do you want to continue the work? |
No. This was working when I marked it for review. I had pinged on the community slack too but received no response. Quite likely that this will work if you resolve the conflicts. |
@developerisnow if you would like to see Telegram integration, you are free to take over this PR work and create a separate PR. |
Summary
Add telegram alert channel. PR once completed must be merged with SigNoz/alertmanager#28
Related Issues / PR's
#4700