Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): add telegram alert channel #5411

Closed
wants to merge 5 commits into from

Conversation

Ellipse0934
Copy link

Summary

Add telegram alert channel. PR once completed must be merged with SigNoz/alertmanager#28

Related Issues / PR's

#4700

Copy link

welcome bot commented Jul 2, 2024

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2024

CLA assistant check
All committers have signed the CLA.

@srikanthccv
Copy link
Member

@Ellipse0934 great progress 🎉

@Ellipse0934
Copy link
Author

On the one hand its "almost" done, I can successfully add a telegram channel and receive messages. Currently no message templating is exposed to the user but its a good feature to have regardless. So I think it's better to have a template defined with the deceiver so the user can set it. We can possibly defer this for another PR if you want or we can start here.

I did accidentally break something, It was working. But now I only get a notification when I change/save the config. Subsequent alerts are sent from query-service to alertmanager but something is failing and the failure is silent. In a way its good because it may likely point to a fragile part and save someone trouble in the future.

There is also the issue of HTML escape. It's not being done correctly. I need to fix this on the alertmanager PR.

Previews:
image
image

@Ellipse0934
Copy link
Author

  1. I was confused about how alerting worked and thought that alert was fired continuously. There was no issue so ignore the previous comment.
  2. Bug with parsemode is fixed. Now the telegram message is correctly sent and rendered as per telegram styling entities.

Let me know if you need any help reviewing. You'll need to create a telegram bot. Instructions for that can be found here: https://core.telegram.org/bots/tutorial

@Ellipse0934 Ellipse0934 marked this pull request as ready for review July 10, 2024 14:12
@developerisnow
Copy link

guys can't wait hearings from you @YounixM , @srikanthccv ! Telegram integration doesn't work for newcomer as me

@srikanthccv
Copy link
Member

This missed my radar. @Ellipse0934 do you want to continue the work?

@Ellipse0934
Copy link
Author

No. This was working when I marked it for review. I had pinged on the community slack too but received no response.

Quite likely that this will work if you resolve the conflicts.

@srikanthccv
Copy link
Member

@developerisnow if you would like to see Telegram integration, you are free to take over this PR work and create a separate PR.

@Ellipse0934 Ellipse0934 deleted the ap/telegram-alerts branch November 10, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants