feat: corrected the handling of relativeTime as null in alertHistory

[SagarRajput-7]

Summary

Earlier logic had params.get(QueryParams.relativeTime) returning as null but in string i.e. "null" hence the nullish operator added to handle and assign the defaultRelativeValue was not working as expected.

Corrected that and checked string null separately

Related Issues / PR's

Screenshots

Screen.Recording.2024-11-06.at.10.45.13.PM.mov

Affected Areas and Manually Tested Areas

• tested current behaviour with relativeTime=null and existing behaviours

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to c8fa90f in 27 seconds

More details

• Looked at 17 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. frontend/src/pages/AlertDetails/hooks.tsx:63

• Draft comment:
  The use of ?? RelativeTimeMap['6hr'] is redundant here because relativeTimeParam will never be undefined due to the ternary operation. Consider simplifying this logic.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The ternary operation checks if relativeTimeParam is 'null' and assigns null if true, otherwise assigns relativeTimeParam. The ?? operator is used to provide a default value if the result is null or undefined. The comment suggests redundancy, but the ?? operator is necessary to handle the case where relativeTimeParam is actually null, not just the string 'null'.
  I might be misunderstanding the use of the ?? operator. It is possible that the ?? operator is indeed redundant if relativeTimeParam can never be null or undefined after the ternary operation.
  The ?? operator is used to handle cases where relativeTimeParam is null, which is a valid scenario given the ternary operation. The comment might be incorrect in suggesting redundancy.
  The comment is incorrect because the ?? operator is necessary to handle cases where relativeTimeParam is null. The comment should be deleted.

Workflow ID: wflow_LDUFvbla3jtiVEfS

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>