Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update events for onboarding part 2 #6397

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Nov 7, 2024

update events for onboarding part 2


Important

Update onboarding event logging to use Org Onboarding naming and add detailed tracking for user actions across onboarding steps.

  • Event Logging:
    • Rename events from User Onboarding to Org Onboarding in AboutSigNozQuestions.tsx, InviteTeamMembers.tsx, OptimiseSignozNeeds.tsx, and OrgQuestions.tsx.
    • Add new events for button clicks and onboarding completion in index.tsx.
    • Log additional data for invite success and failure in InviteTeamMembers.tsx.
  • Behavior:
    • Log Org Onboarding: Answered event in AboutSigNozQuestions.tsx, OptimiseSignozNeeds.tsx, and OrgQuestions.tsx when questions are answered.
    • Log Org Onboarding: Clicked Do Later in InviteTeamMembers.tsx and OptimiseSignozNeeds.tsx when users choose to skip steps.
    • Log Org Onboarding: Invite Team Members Success and Partial Success in InviteTeamMembers.tsx with detailed invite data.
  • Misc:
    • Add constants for event names in index.tsx for better maintainability.

This description was created by Ellipsis for 6e9d180. It will automatically update as commits are pushed.

Copy link

github-actions bot commented Nov 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2155cf9 in 1 minute and 0 seconds

More details
  • Looked at 312 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. frontend/src/container/OnboardingQuestionaire/AboutSigNozQuestions/AboutSigNozQuestions.tsx:85
  • Draft comment:
    The event name 'Org Onboarding: Answered' is used here. Ensure this is consistent across all files for similar events. It is also used in OptimiseSignozNeeds.tsx and OrgQuestions.tsx.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the event names for logging, but there is an inconsistency in the event name for the 'Answered' event. It is used in multiple files, and the name should be consistent across all of them.
2. frontend/src/container/OnboardingQuestionaire/OptimiseSignozNeeds/OptimiseSignozNeeds.tsx:125
  • Draft comment:
    The event name 'Org Onboarding: Answered' is used here. Ensure this is consistent across all files for similar events. It is also used in AboutSigNozQuestions.tsx and OrgQuestions.tsx.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the event names for logging, but there is an inconsistency in the event name for the 'Answered' event. It is used in multiple files, and the name should be consistent across all of them.
3. frontend/src/container/OnboardingQuestionaire/OrgQuestions/OrgQuestions.tsx:97
  • Draft comment:
    The event name 'Org Onboarding: Answered' is used here. Ensure this is consistent across all files for similar events. It is also used in AboutSigNozQuestions.tsx and OptimiseSignozNeeds.tsx.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the event names for logging, but there is an inconsistency in the event name for the 'Answered' event. It is used in multiple files, and the name should be consistent across all of them.
4. frontend/src/container/OnboardingQuestionaire/OptimiseSignozNeeds/OptimiseSignozNeeds.tsx:144
  • Draft comment:
    Avoid using inline styles for the Slider component. Consider using external stylesheets, CSS classes, or styled components instead.
  • Reason this comment was not posted:
    Marked as duplicate.
5. frontend/src/container/OnboardingQuestionaire/OptimiseSignozNeeds/OptimiseSignozNeeds.tsx:122
  • Draft comment:
    Avoid using inline styles for the Slider component. Consider using external stylesheets, CSS classes, or styled components instead.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_SErXCC2vXQII6jJL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@YounixM YounixM removed the request for review from makeavish November 8, 2024 06:35
@YounixM YounixM enabled auto-merge (squash) November 8, 2024 06:43
Copy link

github-actions bot commented Nov 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 6e9d180 in 55 seconds

More details
  • Looked at 312 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. frontend/src/container/OnboardingQuestionaire/InviteTeamMembers/InviteTeamMembers.tsx:182
  • Draft comment:
    Consider using constants for event names instead of hardcoding them. This will improve maintainability and consistency with the rest of the codebase.
  • Reason this comment was not posted:
    Marked as duplicate.
2. frontend/src/container/OnboardingQuestionaire/InviteTeamMembers/InviteTeamMembers.tsx:206
  • Draft comment:
    Consider using constants for event names instead of hardcoding them. This will improve maintainability and consistency with the rest of the codebase.
  • Reason this comment was not posted:
    Marked as duplicate.
3. frontend/src/container/OnboardingQuestionaire/InviteTeamMembers/InviteTeamMembers.tsx:265
  • Draft comment:
    Consider using constants for event names instead of hardcoding them. This will improve maintainability and consistency with the rest of the codebase.
  • Reason this comment was not posted:
    Marked as duplicate.
4. frontend/src/container/OnboardingQuestionaire/OptimiseSignozNeeds/OptimiseSignozNeeds.tsx:144
  • Draft comment:
    Avoid using inline styles for the Slider component. Use external stylesheets or styled components instead. This is also applicable at line 246 and 273.
  • Reason this comment was not posted:
    Comment was on unchanged code.
5. frontend/src/container/OnboardingQuestionaire/index.tsx:1
  • Draft comment:
    Avoid using the component/index.tsx file structure approach. It makes it difficult to debug and find components using global search tools.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_nw8RtKMu2sLn54kT


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@YounixM YounixM merged commit e748fb0 into develop Nov 8, 2024
14 of 15 checks passed
@prashant-shahi prashant-shahi deleted the onboarding-part2-events branch November 8, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants