Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: styles misc fixes #6400

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat: styles misc fixes #6400

merged 2 commits into from
Nov 8, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Nov 8, 2024

Summary

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Adds a new MetricPage view for Kafka metrics with updated styles and components.

  • Behavior:
    • Adds MetricPage view to MQDetailPage.tsx and MessagingQueues.tsx for Kafka metrics.
    • Updates MessagingQueuesViewType in MessagingQueuesUtils.ts to include metricPage.
    • Adds MetricPage component with collapsible sections for JVM and partition metrics in MetricPage.tsx.
  • Styles:
    • Adds styles for MetricPage in MetricPage.styles.scss.
    • Updates styles for light mode across various components, including DropRateView.styles.scss and MQDetails.style.scss.
  • Components:
    • Introduces MetricColumnGraphs and MetricPageGridGraph components for rendering metric graphs in MetricPage.
    • Refactors DropRateView to use updated styles and logic in DropRateView.tsx.
  • Utilities:
    • Adds utility functions for widget query building in MetricPageUtil.ts.

This description was created by Ellipsis for 699a228. It will automatically update as commits are pushed.

Copy link

github-actions bot commented Nov 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 changed the base branch from develop to metric-page-1 November 8, 2024 00:52
@github-actions github-actions bot added the bug Something isn't working label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Nov 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 changed the title Styles misc fixes feat: styles misc fixes Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 merged commit d148a80 into metric-page-1 Nov 8, 2024
5 of 7 checks passed
@SagarRajput-7 SagarRajput-7 deleted the styles-misc-fixes branch November 8, 2024 11:11
@github-actions github-actions bot added the enhancement New feature or request label Nov 8, 2024
SagarRajput-7 added a commit that referenced this pull request Nov 9, 2024
* feat: added metric page in messaging queues

* feat: added misc fixes

* feat: removed a class name from mqcards

* feat: added lightMode styles for kafka 2.0 (#6400)

* feat: resolved comments and used strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants