fix: improve traces table ux by making the table scrollable #6423
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to bcb439e in 31 seconds
More details
- Looked at
27lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/pages/TracesExplorer/TracesExplorer.styles.scss:51
- Draft comment:
Ensure that the width adjustment for.trace-explorerin light mode is consistent with the dark mode to avoid layout issues. Consider usingcalc(100% - 260px)for consistency. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_PlOPAEUtOogskxQX
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -84,7 +84,7 @@ function ResizeTable({ | |||
|
|
|||
| return onDragColumn ? ( | |||
| <ReactDragListView.DragColumn {...dragColumnParams} onDragEnd={onDragColumn}> | |||
| <Table {...tableParams} /> | |||
| <Table {...tableParams} scroll={{ x: 'max-content' }} /> | |||
There was a problem hiding this comment.
Avoid using inline styles for the scroll property. Consider using an external stylesheet or styled components instead.
Suggested change
| <Table {...tableParams} scroll={{ x: 'max-content' }} /> | |
| <Table {...tableParams} /> |
… true to max-content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In case we have too many columns in the list view of traces explorer, the UI breaks, and the columns can't be resized properly. This PR fixes these issues by making the table horizontally scrollable.
Related Issues / PR's
close #6326
Screenshots
2024-11-12.09-56-20.mov
Affected Areas and Manually Tested Areas
Important
Makes the traces explorer table horizontally scrollable to handle cases with too many columns.
ListView/index.tsxhorizontally scrollable by settingscroll={{ x: 'max-content' }}in theResizeTablecomponent..trace-explorerwidth inTracesExplorer.styles.scsstocalc(100% - 260px)to accommodate the scrollable table.This description was created by
for a50bd99. It will automatically update as commits are pushed.