Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add experimental rate/increase calc #6432

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: add experimental rate/increase calc #6432

merged 1 commit into from
Nov 13, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Nov 12, 2024

Summary

Experimenting with expressions used to calculate rate/increase for cumulative counters. This is better than what is already there for cases where the aggregation is performed for the whole window, but I want to see how it works in all scenarios.


Important

Adds experimental rate/increase calculations in timeseries.go, conditionally used based on environment variables.

  • Behavior:
    • Adds experimentalRateWithoutNegative and experimentalIncreaseWithoutNegative expressions in timeseries.go for rate and increase calculations.
    • Uses experimental expressions if EXPERIMENTAL_RATE_WITHOUT_NEGATIVE or EXPERIMENTAL_INCREASE_WITHOUT_NEGATIVE environment variables are set.
  • Functions:
    • Modifies prepareTimeAggregationSubQuery to conditionally use experimental expressions based on environment variables.

This description was created by Ellipsis for 14dbe5d. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Nov 12, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 14dbe5d in 1 minute and 2 seconds

More details
  • Looked at 47 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/app/metrics/v4/cumulative/timeseries.go:5
  • Draft comment:
    Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The code uses environment variables to toggle between experimental and non-experimental expressions for rate and increase calculations. This is a good approach for testing new features without affecting the existing functionality.

Workflow ID: wflow_EHr4uL3qRGEUv5Eh


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv srikanthccv merged commit 323da34 into develop Nov 13, 2024
14 of 16 checks passed
@srikanthccv srikanthccv deleted the test-rate branch November 13, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants