You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, agent creators will be able to specify whether the the graph of their marketplace-listed agent should be publicly accessible (open-source).
Pending this functionality, we want to prevent users from directly accessing graphs that don't belong to them, even if they have a corresponding marketplace listing.
This only prohibits direct read access, not usage of the graph such as running it.
Changes 🏗️
Make access control to marketplace-listed graphs "default deny" in backend.data.graph.get_graph(..)
Add ignore_ownership_if_listed_in_marketplace=True to get_graph calls where necessary
Checklist 📋
For code changes:
I have clearly listed my changes in the PR description
I have made a test plan
I have tested my changes according to the test plan:
...
Example test plan
Create from scratch and execute an agent with at least 3 blocks
Import an agent from file upload, and confirm it executes correctly
Upload agent to marketplace
Import an agent from marketplace and confirm it executes correctly
Edit an agent from monitor, and confirm it executes correctly
This feels like the ui for blocking this access should come before the blocking since most of the agents we have are to teach people how to use the platform right?
Update: for now we'll make all graphs open-source by default, allowing read access to all (published) graphs by all users (ofc still denying write access to anyone other than the owner).
When #9549 is addressed, this PR can be reopened, or the changes included.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
In the future, agent creators will be able to specify whether the the graph of their marketplace-listed agent should be publicly accessible (open-source).
Pending this functionality, we want to prevent users from directly accessing graphs that don't belong to them, even if they have a corresponding marketplace listing.
This only prohibits direct read access, not usage of the graph such as running it.
Changes 🏗️
backend.data.graph.get_graph(..)
ignore_ownership_if_listed_in_marketplace=True
toget_graph
calls where necessaryChecklist 📋
For code changes:
Example test plan