SWPROT-9430: Update Get Node NLS State SAPI command #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasdjb
force-pushed
the
task/thdubois/SWPROT-9430/update-get-node-nls-state
branch
from
455830c to
0e28733
Compare
rzr
approved these changes
Apr 3, 2025
Thomasdjb
force-pushed
the
task/thdubois/SWPROT-9430/update-get-node-nls-state
branch
from
0e28733 to
196745e
Compare
rzr
force-pushed
the
main
branch
2 times, most recently
from
5486b41 to
78dfbc4
Compare
rzr
force-pushed
the
task/thdubois/SWPROT-9430/update-get-node-nls-state
branch
from
196745e to
a7bc82d
Compare
Thomasdjb
force-pushed
the
task/thdubois/SWPROT-9430/update-get-node-nls-state
branch
2 times, most recently
from
66b36d8 to
386fd7d
Compare
|
Test is passing: https://github.com/Thomasdjb/z-wave-protocol-controller/actions/runs/14620981160 Any objection to merge ? |
rzr
force-pushed
the
task/thdubois/SWPROT-9430/update-get-node-nls-state
branch
from
386fd7d to
b536b05
Compare
|
smoketests verified at: https://github.com/Thomasdjb/z-wave-protocol-controller/actions/runs/14732678674/job/41350689776 May we merge after the race fix merge |
rzr
force-pushed
the
main
branch
2 times, most recently
from
2f6e35f to
517fe0e
Compare
lmolina
reviewed
May 21, 2025
applications/zpc/components/zwave/zwave_transports/s2/src/zwave_s2_network.c
Outdated
Show resolved
Hide resolved
applications/zpc/components/zwave_api/include/zwapi_protocol_controller.h
Show resolved
Hide resolved
applications/zpc/components/zwave/zwave_transports/s2/src/zwave_s2_network.c
Show resolved
Hide resolved
Thomasdjb
force-pushed
the
task/thdubois/SWPROT-9430/update-get-node-nls-state
branch
from
f2051eb to
beb3f67
Compare
rzr
force-pushed
the
task/thdubois/SWPROT-9430/update-get-node-nls-state
branch
from
beb3f67 to
fbf1f40
Compare
lmolina
approved these changes
May 22, 2025
rzr
force-pushed
the
task/thdubois/SWPROT-9430/update-get-node-nls-state
branch
from
fbf1f40 to
9ee31eb
Compare
rzr
force-pushed
the
task/thdubois/SWPROT-9430/update-get-node-nls-state
branch
from
9ee31eb to
723993c
Compare
silabs-peterb
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Specification change has been merged:
https://github.com/Z-Wave-Alliance/CSWG/blob/5f137ca1867a359a0523d63d9b2bd1bf2233f4d4/documents/zw-host-api-spec/source/zwave_api_commands/network_management/controller_nodes/get_node_nls_state_command.rst#L4
Checklist