ci: github: Add test action that prepare env for smoketests #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI configuration to prepare the environment for smoketests while limiting PR builds to prevent secret exposure.
- Updated docker-compose configuration with a broker image upgrade and refined service parameters.
- Added a new test workflow (.github/workflows/test.yml) for smoketesting on successful builds.
- Refined the build workflow (.github/workflows/build.yml) to improve build argument clarity and support container image uploads.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.yml | Upgraded broker image version, updated logging and restart policies, and adjusted volumes. |
| .github/workflows/test.yml | Introduced smoketest workflow to trigger on successful build runs and download necessary artifacts. |
| .github/workflows/build.yml | Simplified job name and restructured build arguments along with adding a step to upload the built image. |
Files not reviewed (1)
- Dockerfile: Language not supported
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 17, 2025
It can be then test using smoketest script. For the record reusable workflow are enabled once merged in main branch. ci: github: Only build once in branches Since token will be involved in testing, build on PR is disabled because secrets can not be shared from fork to upstream Origin: SiliconLabsSoftware#84 Relate-to: SOSC-163 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#17 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#15 Relate-to: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions Relate-to: Z-Wave-Alliance/z-wave-stack#733 Signed-off-by: Philippe Coval <[email protected]>
|
You can check result of the test at: https://github.com/rzr/z-wave-protocol-controller/actions/runs/14522947948/job/40747948071 Please merge to enable this action, then I will update my branch to run automated simulated smoketests |
rzr
added a commit
that referenced
this pull request
Apr 18, 2025
It can be then test using smoketest script. For the record reusable workflow are enabled once merged in main branch. ci: github: Only build once in branches Since token will be involved in testing, build on PR is disabled because secrets can not be shared from fork to upstream Origin: #84 Relate-to: SOSC-163 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#15 Relate-to: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions Relate-to: Z-Wave-Alliance/z-wave-stack#733 Signed-off-by: Philippe Coval <[email protected]>
|
To check the workflows I merged by mistake to main , if a problem occurs I will reset head, sorry for bypassing reviewers. |
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 18, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 18, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 18, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 18, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 22, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 22, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 22, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 22, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 22, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 22, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Apr 22, 2025
Origin: SiliconLabsSoftware#85 Relate-to: SiliconLabsSoftware#84 (comment) Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#5 Relate-to: Z-Wave-Alliance/z-wave-stack-binaries#2 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#23 Signed-off-by: Philippe Coval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be then test using smoketest script.
For the record reusable workflow are enabled once merged in main branch.
ci: github: Only build once in branches
Since token will be involved in testing,
build on PR is disabled because secrets can not be shared from fork to upstream
Relate-to: SOSC-163
Relate-to: https://github.com/SiliconLabsSoftware/z-wave-engine-application-layer/issues/17
Relate-to: https://github.com/SiliconLabsSoftware/z-wave-engine-application-layer/issues/15
Relate-to: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions
Change
Checklist