Modularize solver Core and FE components with per-folder CMake targets - #622
Merged
Conversation
updating fork repo with upstream head
update main to upstream branch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 72.89% 72.89% -0.01%
==========================================
Files 258 258
Lines 39499 39501 +2
Branches 6731 6730 -1
==========================================
Hits 28793 28793
- Misses 10462 10464 +2
Partials 244 244 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
michelebucelli
approved these changes
Aug 27, 2026
zasexton
marked this pull request as ready for review
August 27, 2026 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change gives the solver's
Core,FE/Common,FE/Math,FE/Basis, andFE/Quadraturemodules their own CMake target definitions. It replaces thesolver-level collection of their files into the monolithic
CSRCSlist withmodule-owned targets and explicit target dependencies.
The source-bearing FE modules use
OBJECTlibraries. Their object files aretherefore compiled once and incorporated directly into
svmultiphysicsandrun_all_unit_tests, without creating additional shared-library artifacts thatwould need runtime discovery, symbol exports, or installer packaging.
Closes #619.
Changes
INTERFACEtarget forCoreand anINTERFACEtarget forFE/Common.OBJECTtargets forFE/Math,FE/Basis, andFE/Quadrature.CMakeLists.txtthat automatically discovers itssource and header files with
file(GLOB ... CONFIGURE_DEPENDS).its target.
svmultiphysicsandrun_all_unit_testsfrom the moduletargets instead of compiling the same FE sources through their executable
source lists.
the new object targets.
CSRCSadditions for the five modularizeddirectories.
Build and packaging impact
BUILD_SHARED_LIBS=ONstill produce no separatesvmp_fe_*runtime libraries because the source-bearing modules are explicitOBJECTtargets.executable rather than a new collection of FE libraries.
change.