Feature/quarkus vaadin8 integration #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vaadin-cdi uses the same context-instance for Normal and UI-Scoped annotations. The differentiation was introduced to also provide proxies for CDI. Since this caused some issues with the current setup, we had to unify the scopes and therefore remove the normal-scopes.
* Add commons3-lang dependency.
t1m0
commented
Apr 25, 2022
| contexts.add(context); | ||
| } | ||
|
|
||
| Assertions.assertEquals(7, availableScopes.size()); |
quarkus-extension/pom.xml
Outdated
| </dependencies> | ||
| </dependencyManagement> | ||
|
|
||
| </project> |
There was a problem hiding this comment.
no new line at the end
| # guide: ... | ||
| # categories: | ||
| # - "miscellaneous" | ||
| # status: "preview" |
There was a problem hiding this comment.
no new line at the end
| import org.apache.deltaspike.core.util.context.ContextualInstanceInfo; | ||
| import org.apache.deltaspike.core.util.context.ContextualStorage; | ||
|
|
||
| public abstract class AbstractVaadinContext implements InjectableContext { |
There was a problem hiding this comment.
maybe add a reference to deltaspike?
ghost
reviewed
Apr 25, 2022
| @@ -53,6 +49,10 @@ public UIContextualStorageManager getUIContextualStorageManager() { | |||
| return contextualStorageManager; | |||
| } | |||
|
|
|||
| protected ContextualStorage getContextualStorage(Contextual<?> contextual, boolean createIfNotExist) { | |||
There was a problem hiding this comment.
Der Diff könnte aufgehoben werden durch umplatzieren
ghost
approved these changes
Apr 25, 2022
| @@ -77,4 +69,12 @@ && getViewContextualStorageManager() != null | |||
| protected Class<?> getBeanType() { | |||
| return ViewContextualStorageManager.class; | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
Der Diff könnte aufgehoben werden durch umplatzieren
| @Override | ||
| public Class<? extends Annotation> getScope() { | ||
| return ViewScoped.class; | ||
| protected ContextualStorage getContextualStorage(Contextual<?> contextual, boolean createIfNotExist) { |
There was a problem hiding this comment.
Der Diff könnte aufgehoben werden durch umplatzieren
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.