docs(conventions): group thousands with a comma (phaze-xp9nx) - #543
Merged
Conversation
Adds a new section to CONVENTIONS.md next to 'Replace identifiers, never quantities' stating the number-grouping rule: comma grouping (4,383), never space grouping, including four-digit numbers. Documents the measured genre-split evidence (measurement spikes space-grouped, everything else comma-grouped), the PERF-02 false- positive that shows this is a judgement call rather than a mechanical pattern, and points at the companion backfill bead (phaze-3x7xt) converting the existing corpus. Operator decision 2026-08-26 (durable record: phaze-xp9nx): write the convention into CONVENTIONS.md, with comma grouping as the standard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new section to
CONVENTIONS.md, next to "Replace identifiers, never quantities", stating the number-grouping convention for tracked prose: comma grouping (4,383), never space grouping β including four-digit numbers.What it covers
4,383, never4383); decimals keep the comma on the integer part and the period as the decimal point (4,761.835).PERF-02 200Kfalse positive in.planning/milestones/2026.7.5-ROADMAP.mdto show this is a judgement call about meaning, not a mechanical pattern (and why no grep/lint guard is added).docs/**, root-level*.md, spike/design docs, planning notes, commit messages, PR bodies) β not source code.phaze-zaf2l's spike forked because it matched space-grouped exemplars with no written rule to check against.phaze-3x7xt, not silently left inconsistent.Out of scope (deliberately)
phaze-3x7xt.PERF-02 200Kfalse positive.Validation
just check-fastβ green: ruff clean, mypy clean, docs-selector correctly picked the 11 prose-guard modules touchingCONVENTIONS.md(includingtests/shared/test_adr_citation_resolution.pyandtests/shared/test_operator_attribution_citations.py), 194 passed.Bead:
phaze-xp9nxπ€ Generated with Claude Code