Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS-972] Start Capture button to manually prepare for Face Auto-Capture #1084

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

alex-vt
Copy link
Contributor

@alex-vt alex-vt commented Feb 6, 2025

Before:

When using auto-capture and starting the viewfinder, the start of the "sensing" for the qualifying quality face presense in the frame was delayed for 2 seconds.

Now:

When using auto-capture and starting the viewfinder, the start of the "sensing" for the qualifying quality face presense in the frame is delayed until the user taps the "Start capture" button.

@alex-vt
Copy link
Contributor Author

alex-vt commented Feb 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

A note: Even if a useful suggestion - this is ported from the manual capture intentionally and is not truly new code.

Copy link
Contributor

@BurningAXE BurningAXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something not directly but still related - after you trigger auto-capture the button is still active and reacts to taps. Maybe we can disable interactions during capture as they don't make sense.

@alex-vt alex-vt merged commit 780817b into main Feb 6, 2025
9 checks passed
@alex-vt alex-vt deleted the feature/autocapture-start-button branch February 6, 2025 18:07
Copy link

sonarqubecloud bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants