Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS-852] Add explicit class type to the tokenizable fields returned to CoSync #1111

Merged
merged 2 commits into from
Feb 20, 2025
Merged

[MS-852] Add explicit class type to the tokenizable fields returned to CoSync #1111

merged 2 commits into from
Feb 20, 2025

Conversation

BurningAXE
Copy link
Contributor

@BurningAXE BurningAXE commented Feb 19, 2025 •
edited
Loading

  1. Added the concrete class type (Raw or Tokenized) to tokenizable fields returned to CoSync
  2. Given this - optimized CompareImplicitTokenizedStringsUseCase to only probe the tokenization state of TokenizableString.Raw values since if a value is TokenizableString.Tokenized we know its class was explicitly specified and can be sure of its tokenization state

@cla-bot cla-bot bot added the ... label Feb 19, 2025
@BurningAXE BurningAXE changed the title Ms 852 co sync add explicit class type to the tokenized fields when returning to comm care2 [MS-852] Add explicit class type to the tokenized fields returned to CoSync Feb 19, 2025
@BurningAXE BurningAXE changed the title [MS-852] Add explicit class type to the tokenized fields returned to CoSync [MS-852] Add explicit class type to the tokenizable fields returned to CoSync Feb 19, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@BurningAXE BurningAXE requested review from a team, luhmirin-s, alex-vt, meladRaouf, TristramN, ybourgery and alexandr-simprints and removed request for a team February 19, 2025 15:06
@BurningAXE BurningAXE marked this pull request as ready for review February 19, 2025 15:06
@meladRaouf meladRaouf merged commit 0184805 into release/2025.1.0 Feb 20, 2025
12 checks passed
@meladRaouf meladRaouf deleted the MS-852-CoSync-add-explicit-class-type-to-the-tokenized-fields-when-returning-to-CommCare2 branch February 20, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhmirin-s luhmirin-s luhmirin-s approved these changes

@alex-vt alex-vt alex-vt approved these changes

@meladRaouf meladRaouf meladRaouf approved these changes

@TristramN TristramN Awaiting requested review from TristramN TristramN was automatically assigned from Simprints/sid-reviewers

@ybourgery ybourgery Awaiting requested review from ybourgery ybourgery was automatically assigned from Simprints/sid-reviewers

@alexandr-simprints alexandr-simprints Awaiting requested review from alexandr-simprints alexandr-simprints was automatically assigned from Simprints/sid-reviewers

Assignees
No one assigned
Labels
...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BurningAXE @luhmirin-s @alex-vt @meladRaouf