-
-
Notifications
You must be signed in to change notification settings - Fork 16
Update to ImageSharp v3.1.11 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Erik-White
wants to merge
12
commits into
SixLabors:main
Choose a base branch
from
Erik-White:update-imagesharp-dependency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update to ImageSharp v3.1.11 #26
Erik-White
wants to merge
12
commits into
SixLabors:main
from
Erik-White:update-imagesharp-dependency
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erik-White
commented
Oct 17, 2025
Erik-White
commented
Oct 17, 2025
Member
|
Thanks @Erik-White I would love to get this kick started again once I do the next major releases of the main libraries. I've actually had very little to do with the code so will need to conduct a thorough architectural review following a merge. |
Author
|
Great! Thanks for your feedback |
Author
|
I have updated the Texture.From* methods to return exceptions instead of nullable types |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This updates ImageSharp.Textures to use the latest public release of ImageSharp, version 3.1.11
The license has been updated to the Six Labors Split License
It also updates relevant dependencies:
I saw the comment that this repo is not maintained and I understand that you don't have time for it, but it would be shame to let all the obvious effort that has gone into this to go to waste! I would like to find a path forward where I (and I'm sure others) can make use of it, as well as contribute, without being a burden on the ImageSharp team.
(Apologies for the size of the diff, the license changes forced a lot of noise with the updated file headers)